Skip to content

fix: private field in class expression emits invalid dts #61590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: private field in class expression emits invalid dts #61590

wants to merge 2 commits into from

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Apr 17, 2025 •
edited
Loading

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Apr 17, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 17, 2025
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@gabritto
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 17, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/61590/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

tsconfig.base.json

packages/puppeteer-core/tsconfig.json

packages/puppeteer/tsconfig.json

  • [NEW] error TS7006: Parameter 'mutex' implicitly has an 'any' type.
  • [NEW] error TS7006: Parameter 'onRelease' implicitly has an 'any' type.
  • [NEW] error TS7008: Member '#acquirers' implicitly has an 'any[]' type.
  • [NEW] error TS2339: Property '__createBinding' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/injected/injected")'.
  • [NEW] error TS2774: This condition will always return true since this function is always defined. Did you mean to call it instead?
  • [NEW] error TS7006: Parameter 'o' implicitly has an 'any' type.
  • [NEW] error TS7006: Parameter 'm' implicitly has an 'any' type.
  • [NEW] error TS7006: Parameter 'k' implicitly has an 'any' type.
  • [NEW] error TS7006: Parameter 'k2' implicitly has an 'any' type.
  • [NEW] error TS2339: Property '__setModuleDefault' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/injected/injected")'.
  • [NEW] error TS7006: Parameter 'v' implicitly has an 'any' type.
  • [NEW] error TS2339: Property '__importStar' does not exist on type 'typeof import("/mnt/ts_downloads/_/m/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/injected/injected")'.
  • [NEW] error TS7023: 'ownKeys' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • [NEW] error TS7006: Parameter 'mod' implicitly has an 'any' type.
  • [NEW] error TS2322: Type 'undefined' is not assignable to type 'typeof Mutex'.

@typescript-bot
Copy link
Collaborator

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,543k (± 0.76%) 194,818k (± 0.98%) +1,276k (+ 0.66%) 192,953k 196,619k p=0.045 n=6
Parse Time 1.31s (± 0.39%) 1.31s (± 0.48%) ~ 1.30s 1.32s p=0.386 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.74s (± 0.43%) 9.74s (± 0.42%) ~ 9.69s 9.81s p=0.936 n=6
Emit Time 2.73s (± 0.65%) 2.73s (± 0.64%) ~ 2.72s 2.76s p=1.000 n=6
Total Time 14.51s (± 0.33%) 14.51s (± 0.31%) ~ 14.45s 14.58s p=0.936 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,670 948,670 ~ ~ ~ p=1.000 n=6
Types 410,947 410,947 ~ ~ ~ p=1.000 n=6
Memory used 1,224,334k (± 0.00%) 1,224,359k (± 0.00%) ~ 1,224,304k 1,224,433k p=0.297 n=6
Parse Time 6.66s (± 0.43%) 6.64s (± 1.04%) ~ 6.53s 6.71s p=0.936 n=6
Bind Time 1.88s (± 0.44%) 1.89s (± 0.27%) ~ 1.89s 1.90s p=0.073 n=6
Check Time 31.95s (± 0.25%) 31.93s (± 0.27%) ~ 31.84s 32.07s p=0.630 n=6
Emit Time 15.26s (± 0.35%) 15.27s (± 0.75%) ~ 15.10s 15.43s p=0.936 n=6
Total Time 55.76s (± 0.12%) 55.73s (± 0.34%) ~ 55.41s 55.94s p=0.872 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,360,049 2,360,049 ~ ~ ~ p=1.000 n=6
Types 868,091 868,091 ~ ~ ~ p=1.000 n=6
Memory used 2,314,013k (± 0.00%) 2,314,053k (± 0.00%) ~ 2,314,004k 2,314,118k p=0.226 n=6
Parse Time 8.73s (± 0.19%) 8.75s (± 0.22%) ~ 8.73s 8.77s p=0.102 n=6
Bind Time 2.21s (± 1.28%) 2.20s (± 0.68%) ~ 2.19s 2.23s p=0.871 n=6
Check Time 69.82s (± 0.64%) 69.63s (± 0.53%) ~ 69.17s 70.12s p=0.471 n=6
Emit Time 0.31s (± 1.32%) 0.30s (± 3.29%) ~ 0.29s 0.31s p=0.071 n=6
Total Time 81.07s (± 0.55%) 80.88s (± 0.45%) ~ 80.43s 81.39s p=0.575 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,025 1,228,025 ~ ~ ~ p=1.000 n=6
Types 267,258 267,257 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,360,321k (± 0.02%) 2,360,664k (± 0.01%) ~ 2,360,256k 2,361,172k p=0.378 n=6
Parse Time 5.24s (± 0.96%) 5.18s (± 0.58%) -0.06s (- 1.21%) 5.15s 5.23s p=0.030 n=6
Bind Time 1.80s (± 0.82%) 1.81s (± 0.97%) ~ 1.78s 1.83s p=0.625 n=6
Check Time 35.35s (± 0.17%) 35.37s (± 0.58%) ~ 35.16s 35.71s p=0.521 n=6
Emit Time 3.08s (± 2.87%) 3.00s (± 0.94%) -0.09s (- 2.81%) 2.95s 3.03s p=0.024 n=6
Total Time 45.48s (± 0.27%) 45.34s (± 0.41%) ~ 45.21s 45.66s p=0.199 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,025 1,228,025 ~ ~ ~ p=1.000 n=6
Types 267,258 267,257 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,916,344k (±12.88%) 3,159,204k (± 0.02%) ~ 3,158,651k 3,160,071k p=0.298 n=6
Parse Time 6.94s (± 1.81%) 6.97s (± 0.61%) ~ 6.91s 7.03s p=0.936 n=6
Bind Time 2.17s (± 1.07%) 2.16s (± 2.05%) ~ 2.10s 2.22s p=0.688 n=6
Check Time 42.91s (± 0.45%) 42.93s (± 0.14%) ~ 42.84s 43.00s p=0.936 n=6
Emit Time 3.56s (± 2.46%) 3.50s (± 2.25%) ~ 3.40s 3.59s p=0.261 n=6
Total Time 55.56s (± 0.52%) 55.56s (± 0.19%) ~ 55.36s 55.65s p=0.521 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,403 263,403 ~ ~ ~ p=1.000 n=6
Types 107,094 107,093 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 441,723k (± 0.01%) 441,721k (± 0.02%) ~ 441,612k 441,827k p=0.936 n=6
Parse Time 3.57s (± 1.17%) 3.53s (± 1.21%) ~ 3.48s 3.60s p=0.108 n=6
Bind Time 1.32s (± 0.91%) 1.32s (± 0.39%) ~ 1.31s 1.32s p=0.351 n=6
Check Time 19.02s (± 0.32%) 19.00s (± 0.30%) ~ 18.94s 19.10s p=0.630 n=6
Emit Time 1.53s (± 0.68%) 1.54s (± 0.86%) ~ 1.52s 1.56s p=0.358 n=6
Total Time 25.45s (± 0.22%) 25.38s (± 0.32%) ~ 25.26s 25.51s p=0.173 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,981 225,981 ~ ~ ~ p=1.000 n=6
Types 94,356 94,356 ~ ~ ~ p=1.000 n=6
Memory used 371,288k (± 0.02%) 371,281k (± 0.01%) ~ 371,218k 371,339k p=0.936 n=6
Parse Time 2.92s (± 1.03%) 2.89s (± 0.69%) ~ 2.86s 2.92s p=0.169 n=6
Bind Time 1.59s (± 0.95%) 1.60s (± 0.79%) ~ 1.59s 1.62s p=0.121 n=6
Check Time 16.50s (± 0.43%) 16.43s (± 0.20%) ~ 16.39s 16.48s p=0.109 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.00s (± 0.42%) 20.93s (± 0.13%) ~ 20.89s 20.96s p=0.142 n=6
vscode - node (v18.15.0, x64)
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 3,362,299 3,362,299 ~ ~ ~ p=1.000 n=6
Types 1,139,312 1,139,312 ~ ~ ~ p=1.000 n=6
Memory used 3,420,333k (± 0.01%) 3,420,223k (± 0.01%) ~ 3,419,561k 3,420,511k p=0.298 n=6
Parse Time 18.04s (± 0.55%) 17.95s (± 0.28%) ~ 17.89s 18.03s p=0.128 n=6
Bind Time 6.11s (±13.65%) 6.02s (±13.30%) -0.09s (- 1.53%) 5.67s 7.65s p=0.045 n=6
Check Time 111.74s (± 1.29%) 112.56s (± 3.39%) ~ 109.82s 119.90s p=0.689 n=6
Emit Time 35.29s (± 6.99%) 35.22s (± 6.93%) ~ 30.30s 37.01s p=0.810 n=6
Total Time 171.18s (± 1.32%) 171.75s (± 1.52%) ~ 169.57s 176.06s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 316,035 316,035 ~ ~ ~ p=1.000 n=6
Types 140,050 140,050 ~ ~ ~ p=1.000 n=6
Memory used 470,811k (± 0.02%) 470,798k (± 0.02%) ~ 470,663k 470,874k p=0.936 n=6
Parse Time 5.18s (± 0.38%) 5.16s (± 0.61%) ~ 5.10s 5.19s p=0.373 n=6
Bind Time 2.27s (± 1.07%) 2.25s (± 1.08%) ~ 2.22s 2.28s p=0.226 n=6
Check Time 25.88s (± 0.28%) 25.83s (± 0.40%) ~ 25.67s 25.96s p=0.747 n=6
Emit Time 0.00s 0.01s (±109.43%) ~ 0.00s 0.01s p=0.071 n=6
Total Time 33.32s (± 0.24%) 33.24s (± 0.34%) ~ 33.07s 33.34s p=0.226 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 568,548 568,548 ~ ~ ~ p=1.000 n=6
Types 190,459 190,459 ~ ~ ~ p=1.000 n=6
Memory used 498,531k (± 0.01%) 498,553k (± 0.01%) ~ 498,498k 498,648k p=0.378 n=6
Parse Time 3.35s (± 0.70%) 3.37s (± 0.66%) ~ 3.35s 3.41s p=0.569 n=6
Bind Time 1.20s (± 0.87%) 1.20s (± 0.91%) ~ 1.18s 1.21s p=0.554 n=6
Check Time 19.95s (± 0.28%) 20.04s (± 0.47%) ~ 19.94s 20.19s p=0.125 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.51s (± 0.30%) 24.61s (± 0.38%) ~ 24.51s 24.78s p=0.091 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61590/merge:

Something interesting changed - please have a look.

Details

sequelize/sequelize

14 of 16 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.json

@MartinJohns
Copy link
Contributor

Related: #36548 / #57523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaration emit for private identifiers in class expressions is wrong
4 participants
@Jack-Works @typescript-bot @gabritto @MartinJohns